add(test) enable phpunit tests#295
Conversation
132670f to
177b6d0
Compare
10c20e6 to
ec909a0
Compare
94a1d14 to
356960a
Compare
f27893f to
bbcc676
Compare
7bf5469 to
d4d5345
Compare
|
@connorhu would you extract the removal of the Version tag into its own PR? |
Sorry, I don't know how it got there. |
d4d5345 to
7bf5469
Compare
8b393e8 to
0b27f22
Compare
|
|
|
I studied some how-tos and changed my mind. For phpunit testing we will also prefer phar based installs. The composer/script section shows which version is preferred. This can be expanded later if we want to support higher phpunit versions. For now I don't see the sense in this, version 9 will be fine. |
68968e7 to
df367c8
Compare
I would suggest to use phive to install the phar files. We could just ship the '.phive/phive.xml' file in the repo, where versioning is done there. Drawback: the phive will run the installation without checking the currently installed PHP version, we would need to tale some extra care of the versioning, or have 2 phive.xml for php7 and php8 Wdyt? |
I'm going to dig into this and figure out what we can do here with phive. |
|
I have some concerns about this tool. It can do some things but it's a bit awkward to use.
We can live with these gaps, but it's a bit meh. |
and its done.
PR adds phpunit. Unit tests are removed at last and then I will add the finished work bit by bit. I decided to do this because the work was becoming unmanageably large. I know why I did what I did, but for you to see through and approve it, it's easier to go component by component.
this depends on #325